Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable edxapp legacy browser in newrelic.ini.j2 stage and edge #40

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

robrap
Copy link

@robrap robrap commented Jun 17, 2024


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@robrap
Copy link
Author

robrap commented Jun 17, 2024

@timmc-edx:

  1. Do you know if there is any way to easily make this configurable per environment (e.g. stage, or edge)?
  2. If not, should we just pause the pipeline and ensure that Stage seems happy, and then rollout to Edge+Prod?
  3. Other ideas?

@timmc-edx
Copy link
Member

For a hacky approach we could refer to the environment via Ansible variables in that .j2 file.

Co-authored-by: Tim McCormack <tmccormack@edx.org>
@robrap robrap changed the title feat: disable edxapp legacy browser in newrelic.ini.j2 feat: disable edxapp legacy browser in newrelic.ini.j2 stage and edge Jun 20, 2024
@robrap robrap merged commit 4ef1a56 into master Jun 20, 2024
1 check passed
@robrap robrap deleted the robrap/disable-legacy-browser branch June 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants