Skip to content

Commit d3d89a2

Browse files
authored
Revert "feat: import FooterSlot from component package instead of slot package (openedx#1682)"
This reverts commit e16507f.
1 parent 23f836d commit d3d89a2

File tree

7 files changed

+244
-280
lines changed

7 files changed

+244
-280
lines changed

package-lock.json

Lines changed: 235 additions & 269 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"dependencies": {
3535
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
3636
"@edx/browserslist-config": "1.5.0",
37-
"@edx/frontend-component-footer": "^14.6.0",
37+
"@edx/frontend-component-footer": "^14.3.0",
3838
"@edx/frontend-component-header": "^6.2.0",
3939
"@edx/frontend-lib-learning-assistant": "^2.20.0",
4040
"@edx/frontend-lib-special-exams": "^3.5.0",
@@ -47,6 +47,7 @@
4747
"@fortawesome/react-fontawesome": "^0.1.4",
4848
"@openedx/frontend-build": "^14.5.0",
4949
"@openedx/frontend-plugin-framework": "^1.7.0",
50+
"@openedx/frontend-slot-footer": "^1.0.2",
5051
"@openedx/paragon": "^22.16.0",
5152
"@popperjs/core": "2.11.8",
5253
"@reduxjs/toolkit": "1.9.7",

src/generic/CourseAccessErrorPage.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useEffect } from 'react';
22
import { useParams, Navigate } from 'react-router-dom';
33
import { useDispatch, useSelector } from 'react-redux';
44
import { useIntl } from '@edx/frontend-platform/i18n';
5-
import { FooterSlot } from '@edx/frontend-component-footer';
5+
import FooterSlot from '@openedx/frontend-slot-footer';
66
import { LOADED, LOADING } from '@src/constants';
77
import HeaderSlot from '../plugin-slots/HeaderSlot';
88
import useActiveEnterpriseAlert from '../alerts/active-enteprise-alert';

src/generic/PageNotFound.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Hyperlink } from '@openedx/paragon';
33
import { useIntl } from '@edx/frontend-platform/i18n';
44
import { logError } from '@edx/frontend-platform/logging';
55
import { sendTrackEvent } from '@edx/frontend-platform/analytics';
6-
import { FooterSlot } from '@edx/frontend-component-footer';
6+
import FooterSlot from '@openedx/frontend-slot-footer';
77

88
import HeaderSlot from '../plugin-slots/HeaderSlot';
99
import messages from './messages';

src/plugin-slots/FooterSlot/README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
# Footer Slot
22

3-
### Slot ID: `org.openedx.frontend.layout.footer.v1`
4-
5-
### Slot ID Aliases
6-
* `footer_slot`
3+
### Slot ID: `footer_slot`
74

85
## Description
96

107
This slot is used to replace/modify/hide the footer.
118

12-
The implementation of the `FooterSlot` component lives in [the `frontend-component-footer` repository](https://github.com/openedx/frontend-component-footer/).
9+
The implementation of the `FooterSlot` component lives in [the `frontend-slot-footer` repository](https://github.com/openedx/frontend-slot-footer/).
1310

1411
## Example
1512

@@ -26,7 +23,7 @@ import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-frame
2623

2724
const config = {
2825
pluginSlots: {
29-
'org.openedx.frontend.layout.footer.v1': {
26+
footer_slot: {
3027
plugins: [
3128
{
3229
// Hide the default footer

src/plugin-slots/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# `frontend-app-learning` Plugin Slots
22

3-
* [`org.openedx.frontend.layout.footer.v1`](./FooterSlot/)
3+
* [`footer_slot`](./FooterSlot/)
44
* [`org.openedx.frontend.layout.header_learning.v1`](./HeaderSlot/)
55
* [`org.openedx.frontend.learning.content_iframe_loader.v1`](./ContentIFrameLoaderSlot/)
66
* [`org.openedx.frontend.learning.course_breadcrumbs.v1`](./CourseBreadcrumbsSlot/)

src/tab-page/TabPage.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useDispatch, useSelector } from 'react-redux';
55
import { Navigate } from 'react-router-dom';
66

77
import { Toast } from '@openedx/paragon';
8-
import { FooterSlot } from '@edx/frontend-component-footer';
8+
import FooterSlot from '@openedx/frontend-slot-footer';
99
import HeaderSlot from '../plugin-slots/HeaderSlot';
1010
import PageLoading from '../generic/PageLoading';
1111
import { getAccessDeniedRedirectUrl } from '../shared/access';

0 commit comments

Comments
 (0)