Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fire the events for clicking on recommendations, we are passing an array (
expandedList
) to theextractProductKeys
function. This utility function will use that array to determine which LOBs have been expanded in the UI.When clicking on the "Show All" button, we have to make sure to add on the current product type because the
expandedList
that is stored in Context will not be updated by the time this event goes to fire.frontend-app-skills/src/skills-builder/skills-builder-modal/view-results/RecommendationStack.jsx
Line 81 in 41ee70d
This code was unnecessarily duplicated in the two recommendation click events:
edx.skills_builder.recommendaition.expanded.click
andedx.skills_builder.recommendaition.click
. This led to an error where clicking on a card in an unexpanded list of cards generated a payload with the expanded list instead.