Remove OAuth authentication for GitHub #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat
force-pushed
the
nedbat/debug-openedx-fail
branch
from
6a6bfc2
to
1ecfe7c
Compare
|
@Carlos-Muniz @kdmccormick These changes make the bot work well for the openedx organization. |
nedbat
force-pushed
the
nedbat/debug-openedx-fail
branch
from
1ecfe7c
to
cd36b44
Compare
kdmccormick
approved these changes
Dec 16, 2021
added 3 commits
December 17, 2021 11:36
The move from edx to openedx broke the OAuth authentication because the edx org had no OAuth restrictions, but the openedx org does. We don't need OAuth, so just use the personal access token.
nedbat
force-pushed
the
nedbat/debug-openedx-fail
branch
from
ca70542
to
7e4943e
Compare
kdmccormick
approved these changes
Dec 17, 2021
Comment on lines
+33
to
+39
| try: | ||
| ret = pull_request_changed(pull_request) | ||
| log_rate_limit() | ||
| except Exception as exc: | ||
| logger.exception("Couldn't pull_request_changed_task") | ||
| raise | ||
|
|
Comment on lines
+81
to
+84
| except Exception as exc: | ||
| req = response.request | ||
| logger.exception(f"HTTP request failed: {req.method} {req.url}. Response body: {response.content}") | ||
| raise |
Comment on lines
+89
to
+91
| rate = get_github_session().get("/rate_limit").json()['rate'] | ||
| reset = time.strftime("%Y-%m-%d %H:%M:%S", time.localtime(rate['reset'])) | ||
| logger.info(f"Rate limit: {rate['limit']}, used {rate['used']}, remaining {rate['remaining']}. Reset is at {reset}") |
Comment on lines
172
to
173
| if callable(callback): | ||
| callback(resp) |
nedbat
force-pushed
the
nedbat/debug-openedx-fail
branch
from
974fde6
to
6dd1e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, improve the error handling to be sure we can see what's happening when an exception occurs.