Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming conflict with official fluent-plugin-loki #3

Closed
RobertHeim opened this issue May 24, 2019 · 2 comments
Closed

naming conflict with official fluent-plugin-loki #3

RobertHeim opened this issue May 24, 2019 · 2 comments

Comments

@RobertHeim
Copy link

Hi @eeddaann

we appreciate the work you do and open sourcing it! Unfortunately, there is a naming conflict with the fluent-plugin-loki developed within the loki repositories:

Since this is hard to spot and confuses people when following the official loki guide on setting up fluent-plugin-loki, I wonder if you would mind changing the name of your gem file?

Best

@eeddaann
Copy link
Owner

Hi @RobertHeim,
I understand the problem, I'm fine with changing the name.
changing the following line would be enough?

gem.name = "fluent-plugin-loki"

Is it safe to do it? I'm afraid to affect users of this gem...

@RobertHeim
Copy link
Author

the grafana one was renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants