Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect .js imports when used with deno #426

Closed
ctwrs opened this issue Nov 28, 2022 · 2 comments
Closed

Incorrect .js imports when used with deno #426

ctwrs opened this issue Nov 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ctwrs
Copy link

ctwrs commented Nov 28, 2022

Describe the bug
When trying to use this lib in deno I get:

error: Uncaught (in promise) TypeError: Module not found "https://deno.land/x/yaml@v2.1.3/src/parse/parser.js".
at https://deno.land/x/yaml@v2.1.3/src/public-api.ts:16:24

To Reproduce

  1. Install Fresh or any other deno starter.
  2. To import_map.json add "yaml": "https://deno.land/x/yaml@v2.1.3/src/public-api.ts",
  3. deno start task, it will fail on module resolution

Expected behaviour
Source should be compatible with usage as es modules. Alternatively having dist committed along with source would probably fix this too though type annotations would be lost then I think.

Versions (please complete the following information):

Additional context
Deno does have a yaml parser in its std lib, but it reorders arrays which is not nice.

@ctwrs ctwrs added the bug Something isn't working label Nov 28, 2022
@ctwrs
Copy link
Author

ctwrs commented Nov 28, 2022

PEBKAC, their std parser is fine, my code did a .sort on a reference so I'm back to using it.

@ctwrs ctwrs closed this as completed Nov 28, 2022
@eemeli
Copy link
Owner

eemeli commented Nov 29, 2022

This is a duplicate of #301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants