Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforms don't load correctly when running npm linked #21

Open
ef4 opened this issue Feb 9, 2015 · 5 comments
Open

Transforms don't load correctly when running npm linked #21

ef4 opened this issue Feb 9, 2015 · 5 comments

Comments

@ef4
Copy link
Owner

ef4 commented Feb 9, 2015

We look up transform modules relative to ember-browserify, not relative to the user's app. This is only really an issue when running npm linked.

@danny-andrews
Copy link
Contributor

I'm actually having an issue getting transforms to load at all. Specifically, browserify-shim. The transform function is only being passed the core_object-input_staging-6DY6kPE9.tmp/browserify_stubs.js file, and the stubbed define('npm:foo', function(){ return { 'default': require('foo')};}) code so it can't find (and replace) the require's inside my foo module.

@danny-andrews
Copy link
Contributor

False alarm, I didn't realize browserify transforms only work one level deep.

@stefanpenner
Copy link
Collaborator

@ef4 still an issue?

@ef4
Copy link
Owner Author

ef4 commented Apr 27, 2016

Yes. You can reproduce by configuring any babel transform and trying to build your app while ember-browserify is npm linked.

@stefanpenner
Copy link
Collaborator

related: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants