-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include css output in vendor.css rather than app.css? #1
Comments
Do you have a particular use case where it matters whether the scss ends up in app vs vendor? The difficulty is that Sass doesn't really respect such a distinction, so trying to force it ends up forcing people to step outside the Sass conventions. |
I guess it was more so to stick with the Ember convention of vendor css in vendor.css and app css in app.css... I assume it's for allowing more frequently changed code (app.css) to be separated from the less frequently changed stuff (vendor.css) to provide better response & caching/etc when doing updates.. Its likely that once someone sets up the bootstrap stuff they would barely change it - but any update to their app code would incur the cost of re-downloading all the bootstrap code again. I found this as something very difficult to try and work out how to do. I've ended up going with 3 css files: vendor.css (all addon css), app-vendor.css (my vendor.scss in app/styles) and app.css - by adding another entry in the sassOptions.. |
I think we can probably create a convention with a separate top-level file that goes into vendor. Something like |
sounds like a good idea |
Sorry for bringing this up again. This happens in other projects as well. I assume that app-land css changes are more frequent. So, when such a change happens, the whole file invalidates and all the bootstrap styles are redownloaded with it. |
One problem with the documented approach in README is all the bootstrap css would go into the app.css rather than the vendor.css ..
I tried getting this working with an in repo addon but i think the order the addons are loading is causing me issues (not 100%)
The text was updated successfully, but these errors were encountered: