Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v7 #87

Closed
lorcQc opened this issue Dec 2, 2022 · 6 comments
Closed

Release v7 #87

lorcQc opened this issue Dec 2, 2022 · 6 comments
Assignees
Milestone

Comments

@lorcQc
Copy link
Collaborator

lorcQc commented Dec 2, 2022

I think we're ready for release.
If desired, EFCore.VisualBasic.Templates can also be published (although the templates are written in C#..)
Thanks

@lorcQc lorcQc added this to the 7.0.0 milestone Dec 2, 2022
@InteXX
Copy link
Contributor

InteXX commented Dec 2, 2022

Thank you for all your hard work on this.

In the meantime, I can't help but be curious about the requirement that VB templates must be written in C#. Are there some T4 constructs that VB doesn't support? I looked briefly at the files, but nothing jumped out.

@lorcQc
Copy link
Collaborator Author

lorcQc commented Dec 2, 2022

Hello @InteXX,

To be able to compile and run t4 templates outside Visual Studio, EF7 uses an open-source reimplementation of the T4 engine Mono.TextTemplating.

Recently the project was enhanced to support modern C# unfortunately, using csc.exe directly, which broke design-time templates written in VB. Ref

A quick solution would have been to provide here a VB reimplementation of Mono.TextTemplating.Roslyn but the necessary types are protected so not available outside the project...

There is a issue marked with "Help Wanted", if I find the time this winter I will offer my help.

@InteXX
Copy link
Contributor

InteXX commented Dec 3, 2022

That looks interesting.

I'll spread the word.

@bricelam
Copy link
Member

Sorry I'm a bit behind. I still intend to do this.

There's been a few bugs patched in the 7.0 templates for C#. We should port those fixes:

@lorcQc
Copy link
Collaborator Author

lorcQc commented Jan 13, 2023

Thanks a lot,
I will do that this weekend.

@lorcQc lorcQc mentioned this issue Jan 14, 2023
@bricelam
Copy link
Member

Resolved by PR #89

Thank you @lorcQc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants