Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking on Communication #5

Open
xiang90 opened this issue Dec 14, 2013 · 0 comments
Open

Blocking on Communication #5

xiang90 opened this issue Dec 14, 2013 · 0 comments

Comments

@xiang90
Copy link

xiang90 commented Dec 14, 2013

I read through the communication layer.

I think the approach is fine.
Register a RPC paired with channel. Switch on the msg type when receive from TCP , decoding and send to channel.
The upper layer can just use a select on all the receiving channels.
That is very similar to what I have done in raft.

I think one thing we can improve here is that we can try a non-blocking sendMsg when doing broadcast. This can reduce the overall latency if the underlay tcp buffer is full.
But there might be some reason you did a blocking one, so I create this issue.

Also I remember @imoraru talked about multi-threading improvement. But I forgot the details...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant