Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious typo "test/css" in StylesheetTagRenderer.php #276

Open
Defcon0 opened this issue Mar 29, 2018 · 0 comments
Open

Serious typo "test/css" in StylesheetTagRenderer.php #276

Defcon0 opened this issue Mar 29, 2018 · 0 comments

Comments

@Defcon0
Copy link

Defcon0 commented Mar 29, 2018

Hello,

at first thanks for the great plugin you've put together!!

I found an issue in StylesheetTagRenderer.php. Currently in that file we have:

return $this->getTagRenderer()->render(
            'style',
            $formatter->renderLines([
                $name.$formatter->renderSeparator().'{',
                $formatter->renderIndentation($formatter->renderLines($tagStylesheets, true, false)),
                '}',
            ], !empty($tagStylesheets), false),
            array_merge(['type' => 'test/css'], $attributes),
            $newLine
        );

But it needs to be

return $this->getTagRenderer()->render(
            'style',
            $formatter->renderLines([
                $name.$formatter->renderSeparator().'{',
                $formatter->renderIndentation($formatter->renderLines($tagStylesheets, true, false)),
                '}',
            ], !empty($tagStylesheets), false),
            array_merge(['type' => 'text/css'], $attributes),
            $newLine
        );

The type of the style element is 'type' => 'test/css' but it needs to be 'type' => 'text/css'.

Thanks in advance for fixing this ;-)

Bye Defcon0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant