Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @types/depd and @types/koa should be dependencies #257

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 1, 2023

index.d.ts dependency on them

import KoaApplication = require('koa');
import depd = require('depd');
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

index.d.ts dependency on them

```ts
import KoaApplication = require('koa');
import depd = require('depd');
```
@fengmk2 fengmk2 added the bug label Jan 1, 2023
@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Base: 99.76% // Head: 99.76% // No change to project coverage 👍

Coverage data is based on head (c259af7) compared to base (c8898ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2935     2935           
  Branches      546      546           
=======================================
  Hits         2928     2928           
  Misses          7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit 91937c3 into master Jan 1, 2023
@fengmk2 fengmk2 deleted the fix-types-dependencies branch January 1, 2023 16:04
atian25 pushed a commit that referenced this pull request Jan 1, 2023
[skip ci]

## [5.1.1](v5.1.0...v5.1.1) (2023-01-01)

### Bug Fixes

* @types/depd and @types/koa should be dependencies ([#257](#257)) ([91937c3](91937c3))
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant