Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first version #1

Merged
merged 1 commit into from
Jul 15, 2016
Merged

feat: first version #1

merged 1 commit into from
Jul 15, 2016

Conversation

gxcsoccer
Copy link
Contributor

@gxcsoccer gxcsoccer commented Jul 15, 2016 •
edited
Loading

  • 迁移
  • 删除对复数目录的兼容
  • 删除 antx 逻辑（用 appInfo { name, baseDir, env, HOME, pkg } 代替）
  • 删除一些兼容逻辑，例如：customEgg

@gxcsoccer
Copy link
Contributor Author

cc: @popomore

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
README.md
- getAppname: 获取应用名
- loadServerEnv: 加载环境变量
- loadConfig: 加载: config，依赖 antx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antx？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 漏掉了

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

app.name 可以删除了, appname 改为 name ?

image

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
lib/base_loader.js
opt = Object.assign({ lowercaseFirst: true }, opt);
const controllerBase = path.join(this.options.baseDir, 'app/controller');

delete app.controllers;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行不需要了吧？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试可能重复加载

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
lib/base_loader.js
*
* @return {Array} 返回所有目录
*/
loadDirs() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个命名感觉有点疑惑，getLoadDirs？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个已经很多地方在用了，重构的时候再考虑 api 吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

做个别名兼容吧，loader内部使用换名字

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可能会改

fengmk2
fengmk2 reviewed Jul 15, 2016
View reviewed changes
README.md
baseDir: '/path/to/app',
eggPath: '/path/to/framework',
app: app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
lib/plugin_loader.js
* 'xxx-client': {
* enable: true,
* package: 'xxx-client',
* dep: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里会覆盖插件的eggPlugin么？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，这里还少了 eggPlugin

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
lib/plugin_loader.js

// 尝试在以下目录找到匹配的插件
// -> {appname}/node_modules
// -> {clb|midway|chair}/node_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 framework 代替？

atian25
atian25 reviewed Jul 15, 2016
View reviewed changes
package.json
@@ -34,9 +34,18 @@
"egg-ci": "1",
"eslint": "3",
"eslint-config-egg": "3",
"koa": "1",
"koa-router": "4",
"mm": "1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不叫mm了吧？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egg-mock ? 先 mm 了，后面换吧

@gxcsoccer gxcsoccer merged commit d0a4632 into master Jul 15, 2016
@gxcsoccer gxcsoccer deleted the first-version branch July 15, 2016 18:19
@gxcsoccer
Copy link
Contributor Author

+ egg-loader@0.0.2

popomore
popomore reviewed Jul 29, 2016
View reviewed changes
lib/base_loader.js
loadFrameworkPaths() {
const eggPath = this.eggPath;
const frameworkPaths = [];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 customEgg 怎么没了

fengmk2 added a commit that referenced this pull request Jan 13, 2023
@fengmk2
feat: support show app.timing in timline string
1a55c00 
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
                  ▇ [2ms] - #2 Load Plugin
                  ▇ [1ms] - #3 Load Config
                  ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
                  ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
                  ▇ [0ms] - #6 Load extend/application.js
                  ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
                  ▇ [1ms] - #8 Load extend/context.js
                  ▇ [0ms] - #9 Load extend/request.js
                  ▇ [0ms] - #10 Load extend/response.js
                  ▇ [1ms] - #11 Load app.js
                  ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
                  ▇ [0ms] - #13 Require(4) app.js
                  ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
                  ▇ [4ms] - #16 Load Middleware
                  ▇ [4ms] - #17 Load "middlewares" to Application
                  ▇ [2ms] - #18 Load Service
                  ▇ [2ms] - #19 Load "service" to Context
                  ▇ [0ms] - #20 Load Controller
                  ▇ [0ms] - #21 Load "controller" to Application
                  ▇ [0ms] - #22 Load Router
```
fengmk2 added a commit that referenced this pull request Jan 13, 2023
@fengmk2
feat: support show app.timing in timline string (#260)
5b7af12 
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
                  ▇ [2ms] - #2 Load Plugin
                  ▇ [1ms] - #3 Load Config
                  ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
                  ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
                  ▇ [0ms] - #6 Load extend/application.js
                  ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
                  ▇ [1ms] - #8 Load extend/context.js
                  ▇ [0ms] - #9 Load extend/request.js
                  ▇ [0ms] - #10 Load extend/response.js
                  ▇ [1ms] - #11 Load app.js
                  ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
                  ▇ [0ms] - #13 Require(4) app.js
                  ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
                  ▇ [4ms] - #16 Load Middleware
                  ▇ [4ms] - #17 Load "middlewares" to Application
                  ▇ [2ms] - #18 Load Service
                  ▇ [2ms] - #19 Load "service" to Context
                  ▇ [0ms] - #20 Load Controller
                  ▇ [0ms] - #21 Load "controller" to Application
                  ▇ [0ms] - #22 Load Router
```
atian25 pushed a commit that referenced this pull request Jan 13, 2023
@semantic-release-bot
Release 5.3.0
5cc4023 
[skip ci]

## [5.3.0](v5.2.0...v5.3.0) (2023-01-13)

### Features

* support show app.timing in timline string ([#260](#260)) ([5b7af12](5b7af12)), closes [#0](https://github.com/eggjs/egg-core/issues/0) [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) [#10](#10) [#11](#11) [#12](#12) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#17](#17) [#18](#18) [#19](#19) [#20](#20) [#21](#21) [#22](#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gxcsoccer @fengmk2 @atian25 @popomore