Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable app close on parallel #160

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 22, 2023

#159

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 requested a review from killagu February 22, 2023 03:56
@fengmk2 fengmk2 added the bug label Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 53.49% // Head: 85.76% // Increases project coverage by +32.27% 🎉

Coverage data is based on head (5d2b908) compared to base (6f4375c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #160       +/-   ##
===========================================
+ Coverage   53.49%   85.76%   +32.27%     
===========================================
  Files          24       27        +3     
  Lines        2501     2579       +78     
  Branches      147      468      +321     
===========================================
+ Hits         1338     2212      +874     
+ Misses       1163      367      -796     
Impacted Files Coverage Δ
register.js 100.00% <100.00%> (ø)
lib/parallel/agent_register.js 100.00% <0.00%> (ø)
lib/prerequire.js 84.00% <0.00%> (ø)
lib/request_call_function.js 62.50% <0.00%> (ø)
lib/app_handler.js 68.96% <0.00%> (+5.17%) ⬆️
app/extend/agent.js 95.34% <0.00%> (+9.30%) ⬆️
index.js 96.80% <0.00%> (+10.63%) ⬆️
lib/format_options.js 97.77% <0.00%> (+12.22%) ⬆️
lib/utils.js 87.80% <0.00%> (+14.63%) ⬆️
lib/inject_context.js 97.65% <0.00%> (+16.40%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 5a08d33 into master Feb 22, 2023
@fengmk2 fengmk2 deleted the disable-app-close-on-parallel branch February 22, 2023 06:09
fengmk2 pushed a commit that referenced this pull request Feb 22, 2023
[skip ci]

## [5.10.6](v5.10.5...v5.10.6) (2023-02-22)

### Bug Fixes

* disable app close on parallel ([#160](#160)) ([5a08d33](5a08d33))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants