fix: fix mocha failed title for inject_ctx #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.fail is only safe in runTests and should not be called in runSuite.
killagu
commented
Jun 21, 2023
| try { | ||
| app = await appHandler.getApp(suite); | ||
| debug('get app: %s', !!app); | ||
| } catch (err) { | ||
| err.message = `[egg-mock/runSuite] get app for ${getTestTitle(suite)}: ${err.message}`; | ||
| this.fail(suite, err); |
There was a problem hiding this comment.
runner.fail 不应该在 runner.runSuite 中调用，可能导致 mocha 内部状态出问题。
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 85.76% 85.75% -0.02%
==========================================
Files 27 27
Lines 2579 2583 +4
Branches 468 470 +2
==========================================
+ Hits 2212 2215 +3
- Misses 367 368 +1
☔ View full report in Codecov by Sentry. |
fengmk2
pushed a commit
that referenced
this pull request
Jun 21, 2023
[skip ci] ## [5.10.8](v5.10.7...v5.10.8) (2023-06-21) ### Bug Fixes * fix mocha failed title for inject_ctx ([#162](#162)) ([f6f59ac](f6f59ac))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.fail is only safe in runTests and should
not be called in runSuite.
Checklist
npm testpassesAffected core subsystem(s)
Description of change