feat: use egg-logger@3 and sdk-base@4 #167
Conversation
|
Warning Rate limit exceeded@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 2 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes involve upgrading Node.js to include version 22 and updating key package dependencies like Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/node@18.19.33, npm/egg-logger@2.9.1, npm/tsd@0.24.1, npm/typescript@4.9.5 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/nodejs.yml (2 hunks)
- package.json (4 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/nodejs.yml
Additional comments not posted (5)
package.json (5)
35-35: Update toegg-loggerversion^3.5.0approved.Verification successful
Update to
egg-loggerversion^3.5.0is compatible with the current usage ofEggConsoleLoggerandTransportin the codebase. No breaking changes or deprecations affecting these components were found in the changelog.
- Files using
EggConsoleLogger:
lib/parallel/util.jslib/app.js- Files using
Transport:
app/extend/application.jsScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `egg-logger@3` with the current codebase. # Test: Search for `egg-logger` usage in the codebase. Expect: No deprecated methods are used. rg --type js 'egg-logger'Length of output: 357
Script:
#!/bin/bash # Description: Check for changes in `EggConsoleLogger` and `Transport` in `egg-logger` version `^3.5.0`. # Test: Search for `EggConsoleLogger` and `Transport` in the `egg-logger` repository. ast-grep --lang javascript --pattern $'class $_ { $$$ EggConsoleLogger($$$) { $$$ } $$$ }' --repo https://github.com/eggjs/egg-logger ast-grep --lang javascript --pattern $'class $_ { $$$ Transport($$$) { $$$ } $$$ }' --repo https://github.com/eggjs/egg-logger # Test: Check the validity of the documentation link. curl -o /dev/null --silent --head --write-out '%{http_code}' https://github.com/eggjs/egg-logger/blob/master/lib/logger.js#L64Length of output: 783
Script:
#!/bin/bash # Description: Correctly check for changes in `EggConsoleLogger` and `Transport` in `egg-logger` version `^3.5.0`. # Test: Search for `EggConsoleLogger` and `Transport` in the local repository. ast-grep --lang javascript --pattern $'class $_ { $$$ EggConsoleLogger($$$) { $$$ } $$$ }' ast-grep --lang javascript --pattern $'class $_ { $$$ Transport($$$) { $$$ } $$$ }'Length of output: 176
Script:
#!/bin/bash # Description: Broaden the search to verify the presence and usage of `EggConsoleLogger` and `Transport` in the local repository. # Test: Search for any usage of `EggConsoleLogger` and `Transport` without assuming they are defined as classes. rg --type js 'EggConsoleLogger' rg --type js 'Transport'Length of output: 368
Script:
#!/bin/bash # Description: Check the official documentation or changelog of `egg-logger` to verify if `EggConsoleLogger` and `Transport` are still supported in version `^3.5.0`. # Test: Fetch the changelog or relevant documentation sections from the `egg-logger` GitHub repository. curl -s https://raw.githubusercontent.com/eggjs/egg-logger/master/CHANGELOG.mdLength of output: 12308
44-44: Update tosdk-baseversion^4.2.1approved.
59-59: Update to@types/nodeversion20approved.
69-69: Update totsdversion^0.31.1approved.
70-70: Update totypescriptversion5approved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 85.65% 85.50% -0.16%
==========================================
Files 27 27
Lines 2607 2607
Branches 476 470 -6
==========================================
- Hits 2233 2229 -4
- Misses 374 378 +4 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [5.11.0](v5.10.9...v5.11.0) (2024-06-02) ### Features * use egg-logger@3 and sdk-base@4 ([#167](#167)) ([e02e72e](e02e72e))
Summary by CodeRabbit