-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running the Node tasks in a separate subprocess or sandbox #6
Comments
In terms of security, I think The extra features that it might bring us by running the code in a sandbox:
|
I think it's good and enough too. But probably could be replaced with simply const vm = require('vm');
vm.runInNewContext(`
var util = require('util');
if (Boolean(util)) {
console.log(123);
}
console.log(util.isBoolean(true));
`, {
require: require,
console: console
}); |
Actually |
@olstenlarck - I'm the main developer on I agree it's current configuration in main branch is a bit heavy in terms of dependencies, but this is mostly due to some legacy requirements from it's enterprise usage. We've discussed the idea on our end before of creating a dependency like Let me know if you have any questions or ideas about this. It would be relatively easy to create a brand new module to support spawning multiple languages binaries like |
Thanks for the comment on HN https://news.ycombinator.com/item?id=17196329
The text was updated successfully, but these errors were encountered: