fix: Add types file to package.json files #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminparnell
force-pushed
the
add-types-to-package-files
branch
from
fb0c978
to
0314d19
Compare
benjaminparnell
changed the title
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 10 10
Lines 320 320
Branches 113 113
=======================================
Hits 296 296
Misses 23 23
Partials 1 1 Continue to review full report at Codecov.
|
yesmeck
reviewed
Aug 5, 2020
| @@ -4,7 +4,8 @@ | |||
| "description": "Seamless integration between Rollup and PostCSS", | |||
| "main": "dist/index.js", | |||
There was a problem hiding this comment.
"type": "types/index.d.ts",
The type file should be specified here.
There was a problem hiding this comment.
It's already specified on line 33. The file is not published to the registry, so when its installed tools aren't able to find the file, which is why I added it to files
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
While using this module in a project I noticed that the types file specified
doesn't get published to npm when this package is published. I've added it in in this PR.
Thanks for maintaining this module!