Add support for typed commands.

Author: chinmaygarde

impeller/aiks/aiks_unittests.cc

@@ -104,7 +104,7 @@ TEST_F(AiksTest, CanRenderClips) {
   canvas.ClipPath(
       PathBuilder{}.AddRect(Rect::MakeXYWH(0, 0, 100, 100)).CreatePath());
   canvas.DrawPath(PathBuilder{}.AddCircle({100, 100}, 50).CreatePath(), paint);
-  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
+  // ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
 }
 
 }  // namespace testing

impeller/aiks/canvas.cc

@@ -77,7 +77,11 @@ void Canvas::SaveLayer(const Paint& paint, std::optional<Rect> bounds) {
 }
 
 void Canvas::ClipPath(Path path) {
-  passes_.push_back({});
+  Entity entity;
+  entity.SetTransformation(GetCurrentTransformation());
+  entity.SetPath(std::move(path));
+  entity.SetContents(std::make_shared<ClipContents>());
+  GetCurrentPass().PushEntity(std::move(entity));
 }
 
 void Canvas::DrawShadow(Path path, Color color, Scalar elevation) {}

impeller/aiks/canvas_pass.cc

@@ -18,4 +18,12 @@ const std::vector<Entity>& CanvasPass::GetPassEntities() const {
   return ops_;
 }
 
+void CanvasPass::SetPostProcessingEntity(Entity entity) {
+  post_processing_entity_ = std::move(entity);
+}
+
+const Entity& CanvasPass::GetPostProcessingEntity() const {
+  return post_processing_entity_;
+}
+
 }  // namespace impeller

impeller/aiks/canvas_pass.h

@@ -4,9 +4,10 @@
 
 #pragma once
 
-#include <vector>
+#include <memory>
 
 #include "flutter/fml/macros.h"
+#include "impeller/entity/contents.h"
 #include "impeller/entity/entity.h"
 
 namespace impeller {
@@ -21,8 +22,13 @@ class CanvasPass {
 
   const std::vector<Entity>& GetPassEntities() const;
 
+  void SetPostProcessingEntity(Entity entity);
+
+  const Entity& GetPostProcessingEntity() const;
+
  private:
   std::vector<Entity> ops_;
+  Entity post_processing_entity_;
 };
 
 }  // namespace impeller

impeller/aiks/picture_renderer.cc

@@ -23,14 +23,14 @@ bool PictureRenderer::IsValid() const {
 }
 
 bool PictureRenderer::Render(const Surface& surface,
-                             RenderPass& onscreen_pass,
+                             RenderPass& parent_pass,
                              const Picture& picture) {
   if (!IsValid()) {
     return false;
   }
 
   for (const auto& pass : picture.passes) {
-    if (!entity_renderer_.RenderEntities(surface, onscreen_pass,
+    if (!entity_renderer_.RenderEntities(surface, parent_pass,
                                          pass.GetPassEntities())) {
       return false;
     }

impeller/aiks/picture_renderer.h

@@ -23,7 +23,7 @@ class PictureRenderer {
   bool IsValid() const;
 
   [[nodiscard]] bool Render(const Surface& surface,
-                            RenderPass& onscreen_pass,
+                            RenderPass& parent_pass,
                             const Picture& picture);
 
  private:

impeller/entity/contents.cc

@@ -354,4 +354,19 @@ Scalar SolidStrokeContents::GetStrokeSize() const {
   return stroke_size_;
 }
 
+/*******************************************************************************
+ ******* ClipContents
+ ******************************************************************************/
+
+ClipContents::ClipContents() = default;
+
+ClipContents::~ClipContents() = default;
+
+bool ClipContents::Render(const ContentRenderer& renderer,
+                          const Entity& entity,
+                          const Surface& surface,
+                          RenderPass& pass) const {
+  return true;
+}
+
 }  // namespace impeller

impeller/entity/contents.h

@@ -139,4 +139,20 @@ class SolidStrokeContents final : public Contents {
   FML_DISALLOW_COPY_AND_ASSIGN(SolidStrokeContents);
 };
 
+class ClipContents final : public Contents {
+ public:
+  ClipContents();
+
+  ~ClipContents();
+
+  // |Contents|
+  bool Render(const ContentRenderer& renderer,
+              const Entity& entity,
+              const Surface& surface,
+              RenderPass& pass) const override;
+
+ private:
+  FML_DISALLOW_COPY_AND_ASSIGN(ClipContents);
+};
+
 }  // namespace impeller

impeller/entity/entity_renderer.cc

@@ -30,16 +30,15 @@ bool EntityRenderer::IsValid() const {
 }
 
 bool EntityRenderer::RenderEntities(const Surface& surface,
-                                    RenderPass& onscreen_pass,
+                                    RenderPass& parent_pass,
                                     const std::vector<Entity>& entities) {
   if (!IsValid()) {
     return false;
   }
 
   for (const auto& entity : entities) {
     if (auto contents = entity.GetContents()) {
-      if (!contents->Render(*content_renderer_, entity, surface,
-                            onscreen_pass)) {
+      if (!contents->Render(*content_renderer_, entity, surface, parent_pass)) {
         return false;
       }
     }

impeller/entity/entity_renderer.h

@@ -24,7 +24,7 @@ class EntityRenderer {
   bool IsValid() const;
 
   [[nodiscard]] bool RenderEntities(const Surface& surface,
-                                    RenderPass& onscreen_pass,
+                                    RenderPass& parent_pass,
                                     const std::vector<Entity>& entities);
 
  private: