-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use CFBundleName instead of CFDisplayBundleName for .app name #5
Comments
Why? Is there any reason CFBundleName is better? https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundlename |
Because that is what I read on https://github.com/egramtel/dotnet-bundle/blob/master/README.md:
And that is what Xcode does (and Visual Studio for Mac as well on Xamarin project templates) |
Actually it could be even better to have a separate option for setting bundle filename so I can avoid renaming my system extension bundles (which are required to have a filename matching their bundle identifier with |
Yes, I think we could go with custom property and fallback to CFBundleName if it's not set. |
I think this should use
CFBundleName
to determine output .app name, notCFBundleDisplayName
dotnet-bundle/DotNet.Bundle/StructureBuilder.cs
Line 18 in 7e681e6
The text was updated successfully, but these errors were encountered: