Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use CFBundleName instead of CFDisplayBundleName for .app name #5

Open
LuKePicci opened this issue Mar 23, 2021 · 4 comments
Open

Comments

@LuKePicci
Copy link

LuKePicci commented Mar 23, 2021

I think this should use CFBundleName to determine output .app name, not CFBundleDisplayName

public string AppDirectory => Path.Combine(Path.Combine(PublishDirectory, _task.CFBundleDisplayName + ".app"));

@LuKePicci
Copy link
Author

LuKePicci commented Apr 2, 2021

Because that is what I read on https://github.com/egramtel/dotnet-bundle/blob/master/README.md:

<CFBundleName>AppName</CFBundleName> <!-- Also defines .app file name -->
<CFBundleDisplayName>App Name</CFBundleDisplayName>
<CFBundleIdentifier>com.example</CFBundleIdentifier>
...

And that is what Xcode does (and Visual Studio for Mac as well on Xamarin project templates)

@LuKePicci
Copy link
Author

LuKePicci commented Apr 2, 2021

Actually it could be even better to have a separate option for setting bundle filename so I can avoid renaming my system extension bundles (which are required to have a filename matching their bundle identifier with .systemextension filename extension).

@x2bool
Copy link
Contributor

x2bool commented Apr 2, 2021

Yes, I think we could go with custom property and fallback to CFBundleName if it's not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants