Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSCheckValidation line 202 code error #387

Open
philoooooo opened this issue Jul 9, 2024 · 2 comments
Open

DNSCheckValidation line 202 code error #387

philoooooo opened this issue Jul 9, 2024 · 2 comments

Comments

@philoooooo
Copy link

Hello,
On line 202 ->
if (empty($dnsRecord['target']) || $dnsRecord['target'] === '.') {

if record target = 0, empty ->true.

Wouldn't it be better with :
if ((array_key_exists('target',$dnsRecord) && $dnsRecord['target'] == null) || $dnsRecord['target'] === '.') {

?

Thanks
Phil

@philoooooo
Copy link
Author

FYI
maytronics.fr has address 35.181.64.71
maytronics.fr mail is handled by 10 mx2.hc1114-74.c3s2.iphmx.com.
maytronics.fr mail is handled by 0 mx1.hc1114-74.c3s2.iphmx.com.

See the 0 in the target ?

@egulias
Copy link
Owner

egulias commented Sep 4, 2024

Hey @philoooooo
Happy to merge a PR with the updated code, including a test for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants