Update intervals #367
Merged
Update intervals #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 20 20
Lines 668 668
=======================================
Hits 656 656
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I developed this by looking at the requests the web app makes in chrome dev-tools and verified it with the app. By now I do not use the tracker anymore. Maybe they changed the app and the tracker firmware. I am in favor of aligning with the app. If we send update intervals not supported by the app, but the backend accepts it, it could still confuse the firmware on the tracker if they forgot to properly clean the data. |
eifinger
requested changes
Mar 6, 2024
eifinger
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again changing intervals after having debugged the Weenect API and current app (Android and mobile web app). I can't tell though if there are different intervals for dog vs cat vs kid trackers. Furthermore I changed the default setting from
30Mto10Msince that is the max. official interval and will show in the Android app' s UI.Intervals that can be set through the apps:
0S/30S/1M/2M/3M/5M/10MIntervals the API accepts:
0S-99Sor0M-99M.It is not possible to set hours (e.g.
1H). I wasn't able to test if the tracker itself respects non official intervals (e.g. 13M, 60M, 99S) and would actually send the GPS signal at a non-official ("custom") interval. They are stored though server-side for the tracker and displayed in the mobile web app (since there is no slider to set the interval but rather a text display of the setting).Furthermore I added battery life information from the mobile web app.