fix!: some sensors should be "unavailable" when the tracker is offline #372
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 98.20% 98.12% -0.09%
==========================================
Files 20 20
Lines 668 799 +131
==========================================
+ Hits 656 784 +128
- Misses 12 15 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eifinger
changed the title
eifinger
changed the title
tests/conftest.py
Outdated
| @@ -112,7 +112,19 @@ def get_trackers_phone_call_available_subtrahend_missing_fixture(): | |||
| def get_trackers_not_a_pet_tracker_missing_fixture(): | |||
| """Static result when retrieving data from weenect.""" | |||
| response = copy.deepcopy(GET_RACKERS_RESPONSE) | |||
| response["items"][0]["type"] = "familykid" | |||
| response["items"][0]["position"][0]["type"] = "familykid" | |||
There was a problem hiding this comment.
nope, I'm just ill and need sleep. deleted something unintentionally and put it back together incorrectly. thanks for the hint :)
There was a problem hiding this comment.
I need to get pytest running locally in order to test outside of the public.... haven't had time to get it running yet.
There was a problem hiding this comment.
It's a real hastle with poetry. I will change this project to rye in the coming days
|
Nice! Thank you!! |
Following sensors IMHO should not retain their last value but rather show up as unavailable when the tracker itself is offline (either because it is turned off or because it has no reception):
binary sensors
sensors
One could argue to let the battery retain its last state. IMHO it is better to indicate that the state is unclear. In the end the actual value could be far off from the last retained one. I'm not married to that idea though. The other sensors though definitely make no sense to expose when there's no signal.