-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Felt Regex validation #861
Comments
Hi @arkoc , thank you for describing the issue. The regex is actually from the official RPC spec, so it can't be invalid by definition. Leading zeros are explicitly forbidden: https://github.com/starkware-libs/starknet-specs/blob/76bdde23c7dae370a3340e40f7ca2ef2520e75b9/api/starknet_api_openrpc.json#L1338 The problem is that the regex is not respected, but this can be easily mitigated on the Beerus side quite easily. I will post updates here in the issue comments, so don't worry this should be a quick one. |
Thanks for clarification @dwiekawki. We assumed that the issue was the regex, because when we removed it, everything worked. |
Fixed version is deployed to https://dwiekawki.github.io/beerus-wasm-demo/. |
Steps to reproduce
This is calling
total_supply()
function.Response:
Also a side note, when any of functions are returning null (
0x
) it is not parsed correctly as well.The text was updated successfully, but these errors were encountered: