Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilize prost::decode_length_delimiter and prost::length_delimiter_len to pre-alloc when decoding messages in Exchange #43

Closed
zvolin opened this issue Sep 5, 2023 · 0 comments · Fixed by #64
Closed

utilize prost::decode_length_delimiter and prost::length_delimiter_len to pre-alloc when decoding messages in Exchange #43

zvolin opened this issue Sep 5, 2023 · 0 comments · Fixed by #64
Assignees
@fl0rek
Milestone
Header store and ...

Comments

@zvolin
Copy link
Member

zvolin commented Sep 5, 2023 •
edited
Loading

We could try to utilize prost::decode_length_delimiter and prost::length_delimiter_len to just pre-alloc the needed vector that we'll read to.

Originally posted by @zvolin in #42 (comment)
@zvolin zvolin added this to Lumina Sep 6, 2023
@zvolin zvolin moved this to Todo in Lumina Sep 6, 2023
@zvolin zvolin added this to the Header store and sync milestone Sep 6, 2023
@fl0rek fl0rek self-assigned this Sep 7, 2023
@fl0rek fl0rek moved this from Todo to In Progress in Lumina Sep 8, 2023
@fl0rek fl0rek mentioned this issue Sep 11, 2023
Merged
@fl0rek fl0rek moved this from In Progress to In Review in Lumina Sep 11, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Lumina Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fl0rek fl0rek

Labels
None yet
Projects
Lumina
Status: Done
Milestone
Header store and sync
Development

Successfully merging a pull request may close this issue.

feat(exchange): Add pre-allocating the buffer for reading in HeaderCodec fl0rek/celestia-node-rs
2 participants
@fl0rek @zvolin