Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP: Review panic usage #161

Closed
jmg-duarte opened this issue Jul 29, 2024 · 1 comment
Closed

SP: Review panic usage #161

jmg-duarte opened this issue Jul 29, 2024 · 1 comment
Assignees
@jmg-duarte
Labels
bug Something isn't working pallet-storage-provider Relates to the Storage Provider Pallet
Milestone
Phase 1

Comments

@jmg-duarte
Copy link
Contributor 

          right, but we cannot use `.expect` (`panic!()`) in `no_std`, it may compile in tests, but will fail not-gracefully in runtime

Originally posted by @th7nder in #113 (comment)
This was referenced Jul 29, 2024
Merged
Closed
@jmg-duarte jmg-duarte added this to the Phase 1 milestone Jul 30, 2024
@jmg-duarte jmg-duarte added bug Something isn't working pallet-storage-provider Relates to the Storage Provider Pallet labels Jul 30, 2024
@jmg-duarte jmg-duarte assigned cernicc and th7nder and unassigned cernicc Jul 30, 2024
@jmg-duarte jmg-duarte changed the title [Storage Provider] Review panic usage SP: Review panic usage Jul 31, 2024
@th7nder th7nder assigned jmg-duarte and unassigned th7nder Aug 1, 2024
@jmg-duarte
Copy link
Contributor Author

Other chains make use of expect as a way to signal something will not fail:

Closing this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmg-duarte jmg-duarte

Labels
bug Something isn't working pallet-storage-provider Relates to the Storage Provider Pallet
Projects
None yet
Milestone
Phase 1
Development

No branches or pull requests
3 participants
@cernicc @th7nder @jmg-duarte