Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect identifier for actors coming from Pipes or Forwards #241

Open
sleipnir opened this issue Aug 23, 2023 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers protocol Specification of protocol proxy sdks Support languages
Milestone

Comments

@sleipnir
Copy link
Member

Describe the bug

The protocol defines some types for workflos events such as pipes and forwards that do not have all the attributes so that it is possible to identify the target actor.
I suggest that we change to use the ActorId in these types

At the moment:

// Sends the output of a action of an Actor to the input of another action of an Actor
// Useful for handle `pipes` pattern:
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/PipesAndFilters.html
message Pipe {
  // Target Actor
  string actor = 1;

  // Action. 
  string action_name = 2;
}

// Sends the input of a action of an Actor to the input of another action of an Actor
// Useful for handle `content-basead router` pattern
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/ContentBasedRouter.html
message Forward {
  // Target Actor
  string actor = 1;

  // Action. 
  string action_name = 2;
}

Improvement suggestion:

// Sends the output of a action of an Actor to the input of another action of an Actor
// Useful for handle `pipes` pattern:
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/PipesAndFilters.html
message Pipe {
  // Target Actor
  eigr.functions.protocol.actors.ActorId actor = 1;

  // Action. 
  string action_name = 2;
}

// Sends the input of a action of an Actor to the input of another action of an Actor
// Useful for handle `content-basead router` pattern
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/ContentBasedRouter.html
message Forward {
  // Target Actor
  eigr.functions.protocol.actors.ActorId actor = 1;

  // Action. 
  string action_name = 2;
}

ping @eliasdarruda @marcellanz

@sleipnir sleipnir added bug Something isn't working good first issue Good for newcomers protocol Specification of protocol proxy sdks Support languages labels Aug 23, 2023
@sleipnir sleipnir added this to the v1.0.0 milestone Aug 23, 2023
@sleipnir sleipnir moved this to Todo in Spawn v1.0.0 Aug 23, 2023
@sleipnir sleipnir changed the title [BUG] Title of the bug here [BUG] Incorrect identifier for actors coming from Pipes or Forwards Aug 23, 2023
@sleipnir sleipnir removed this from Spawn v1.0.0 Dec 3, 2023
@sleipnir sleipnir moved this to Todo in Spawn v1.5.0 Dec 3, 2023
@sleipnir sleipnir removed this from Spawn v1.5.0 Sep 19, 2024
@sleipnir sleipnir modified the milestones: v1.0.0, 1.6.0 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers protocol Specification of protocol proxy sdks Support languages
Projects
None yet
Development

No branches or pull requests

1 participant