Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptParameters, constructorFromUse, and methodFromUse cleanups #310

Closed
wmdietl opened this issue Jul 21, 2022 · 1 comment
Closed

adaptParameters, constructorFromUse, and methodFromUse cleanups #310

wmdietl opened this issue Jul 21, 2022 · 1 comment

Comments

@wmdietl
Copy link
Member

wmdietl commented Jul 21, 2022

AnnotatedTypes#adaptParameters is called after calls to constructorFromUse and methodFromUse.
The xFromUse methods should already return the signature of an executable element for that particular use.

The handling of synthetic constructor parameters is also inconsistent. If they are in the parameter list, we need to make sure there are corresponding arguments in invocations.
At the moment, these parameters are simply dropped from the parameter list, without checking that the types actually match.
In certain situations that is okay, e.g. for an anonymous constructor no explicit types can be provided.
But is it okay e.g. for an implicit outer this parameter? Shouldn't these be checked against the (implicit) argument?

@wmdietl
Copy link
Member Author

wmdietl commented Feb 22, 2023

The adaptParameters calls are fixed by #406.
The enclosing receiver issue is fixed by #405.
For the handling of synthetic parameters, there is a new issue #400.

@wmdietl wmdietl closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant