Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logarithm in function _component_log_likelihood in mfa.py #3

Open
salwig opened this issue Jun 20, 2024 · 0 comments
Open

Missing logarithm in function _component_log_likelihood in mfa.py #3

salwig opened this issue Jun 20, 2024 · 0 comments

Comments

@salwig
Copy link

salwig commented Jun 20, 2024

Dear @eitanrich,

It seems there is a missing logarithm in the function _component_log_likelihood in mfa.py (line 103).

Currently, it is written as:

return PI.reshape(1, K) + log_prob_data_given_components.T

I believe it should be:

return torch.log(PI).reshape(1, K) + log_prob_data_given_components.T

Could you please review this and update it if necessary?

Thank you in advance!

@salwig salwig changed the title Missing logarithm in function "_component_log_likelihood" in mfa.py Missing logarithm in function _component_log_likelihood in mfa.py Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant