Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in the gn Function Implementation in PyEIT Framework #97

Open
Ling991028 opened this issue Nov 6, 2023 · 1 comment
Open

Comments

@Ling991028
Copy link

I am a student researching Electrical Impedance Tomography (EIT). While using the gn function, I encountered an inconsistency. In the paper "pyEIT: A Python-based Framework for Electrical Impedance Tomography," the update equation for x0 is stated as x0 + (J^TJ + lambR)^(-1)J^Tr0. However, in the gn function, it seems to be implemented as x0 - (J^TJ + lambR)^(-1)J^Tr0. After comparing the representations of each symbol, I found no discrepancies, yet there is a difference in the positive/negative sign. Could you kindly explain this inconsistency?
I would greatly appreciate any insights or clarification you could provide regarding this matter. Thank you for your time and assistance.

@liubenyuan
Copy link
Collaborator

Hi, if r is the residual of $r=(f(x) - f)$, then minimizing a nonlinear least square $\sum r_i^2$ equals $x_{k+1} = x_{k} - (J^TJ)^{-1}J^Tr$, which is the static EIT imaging in gn.

In original paper, I derived the equation using r=(f - f(x)) for ease of dynamic EIT imaging, which takes the difference of $f_{n+1}$ and $f_{n}$.

These are surely misleading and I am sorry for this inconvenience. As you dig further, there are many minus signs in the final step of some dynamic imaging algorithms. We may create an PR writing a detailed document (I am currently out of academe for about an year) on these issues.

Thanks for using pyeit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants