Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZeroMQ support -- Jupyter kernel #17

Closed
ejgallego opened this issue Jun 22, 2016 · 16 comments
Closed

ZeroMQ support -- Jupyter kernel #17

ejgallego opened this issue Jun 22, 2016 · 16 comments

Comments

@ejgallego
Copy link
Collaborator

ejgallego commented Jun 22, 2016

The title says it all. This is a first step towards becoming a Jupyter kernel. The basic resources are:

@cpitclaudel
Copy link
Collaborator

Sounds really exciting!

@ejgallego ejgallego self-assigned this Jun 27, 2016
@ejgallego
Copy link
Collaborator Author

ejgallego commented Jun 29, 2017

Some more discussion on ZeroMQ in Ocaml here:

https://sympa.inria.fr/sympa/arc/caml-list/2016-07/msg00181.html

[unfortunately, the ocaml mailing list is not accessible to google]

@bsdz
Copy link

bsdz commented Jul 23, 2017

Hi, I'm just curious if there's any reason one cannot leverage work done on integrating ocaml with jupyter. That project appears to have implemented their own zeromq interface. I should add I am no expert in ocaml/coq and my knowledge of zeromq is minimal (coming from a python background).

@ejgallego
Copy link
Collaborator Author

@bsdz indeed that is the plan; I guess we are all just short on time / working on other stuff [in my case I am using my free time trying to tweak Coq upstream itself so clients such as SerAPI have a better time interacting with it]

Any help here will be more than welcome!

@bsdz
Copy link

bsdz commented Jul 23, 2017

Thanks for the info @ejgallego. If I can help, I will; although, initially only from a testing perspective.

@XVilka
Copy link

XVilka commented Jan 4, 2018

There is a better (and more modern) implementation of OCaml kernel for Jupyter by the way : https://github.com/akabe/ocaml-jupyter

@ejgallego
Copy link
Collaborator Author

Thanks @XVilka , the info is really appreciated.

@ejgallego
Copy link
Collaborator Author

For those interested, we plan to work on the first prototype at the Coq Implementors Workshop 2018 if I can finally attend. We will use the SerAPI toplevel + @akabe 's OCaml bindings.

@cpitclaudel
Copy link
Collaborator

How are you planning to handle backtracking? Will it be more OCaml-style (redefinitions override previous definitions?)

@ejgallego
Copy link
Collaborator Author

How are you planning to handle backtracking? Will it be more OCaml-style (redefinitions override previous definitions?)

There is no notion of "backtracking" in the Coq document model, but rather Coq maintains an internal document representation, that is synchronized with the Jupyter document, so indeed certain changes may force invalidation, etc... We will see how well it fits, but in principle, adding an already existing definition would error. Until the new document model can land in Coq, I will use a compat layer that should take care of the most pressing subjects.

p.s: IMVHO the word "backtracking" applied to Coq documents used incorrectly, as the usual meaning is in the context of proof search.

@cpitclaudel
Copy link
Collaborator

We will see how well it fits, but in principle, adding an already existing definition would error.

OK :)

p.s: IMVHO the word "backtracking" applied to Coq documents used incorrectly, as the usual meaning is in the context of proof search.

I tend to use both the algorithmic sense and the usual one, "reverse one's previous action or opinion."

@ejgallego
Copy link
Collaborator Author

ejgallego commented Apr 19, 2018

Lately I tend to prefer the model of "updating the document" to "reversing a concrete edit or checking action".

@ejgallego ejgallego removed this from the 0.2 milestone Sep 20, 2018
@brando90
Copy link

brando90 commented Feb 2, 2019

I saw the Python interface issue is linked to this. Sorry if this a naive question, but how is this issue related to it?

@ejgallego
Copy link
Collaborator Author

I saw the Python interface issue is linked to this. Sorry if this a naive question, but how is this issue related to it?

I feel like implementing Jupyter kernels is better done in Python; thus if we would complete the Python interface that could significantly help this issue.

@ejgallego
Copy link
Collaborator Author

ejgallego added a commit that referenced this issue Feb 14, 2023
Thanks to everyone that helped and used this project for almost 7
years!

The following issues are solved by coq-lsp:

closes #252, closes #261, closes #234, closes #202, closes #117,
closes #49, closes #32, closes #26, closes #24, closes #21,
closes #18, closes #17, closes #13
@ejgallego
Copy link
Collaborator Author

Jupyter protocol is for now not planned, in favor of coq-lsp

@Alizter Alizter reopened this Feb 15, 2023
@Alizter Alizter closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants