forked from BigFatDog/cubism-es
-
Notifications
You must be signed in to change notification settings - Fork 1
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: ekacnet/cubism-es
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.1.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: ekacnet/cubism-es
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 16 commits
- 38 files changed
- 1 contributor
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37b45a7 - Browse repository at this point
Copy the full SHA 37b45a7View commit details -
Get rid of a warning related to babel about using an implicit value. Remove warning about circular deps in the dev config, it was already done in the usual one. Change the folders that trigger the reload in the dev config, when I first created the file I took inspiration of what was done for a grafana plugin but here it's better to monitor 2 folders.
Configuration menu - View commit details
-
Copy full SHA for 85ca037 - Browse repository at this point
Copy the full SHA 85ca037View commit details -
Fix broken variables in the keydown functions
Note it seems not to produce the behavior expected
Configuration menu - View commit details
-
Copy full SHA for 3cceff0 - Browse repository at this point
Copy the full SHA 3cceff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for da9353f - Browse repository at this point
Copy the full SHA da9353fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a47fb24 - Browse repository at this point
Copy the full SHA a47fb24View commit details -
Handle selectAll().node() returning null
It seems that when used in some react components the function could return a null object. I suspect it's because we have some timeout still running even when the component that use cubism is unmounted.
Configuration menu - View commit details
-
Copy full SHA for ad1db31 - Browse repository at this point
Copy the full SHA ad1db31View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a05224e - Browse repository at this point
Copy the full SHA a05224eView commit details
Commits on Apr 29, 2024
-
This should address the issue in BigFatDog#9. There is two part in the change itself one to allow the user to interact with the graph to indicate wich area of the graph should be zoomed and one to actually to allow redrawing the graph with zoomed data. The data model for cubism didn't map very well with the later, metrics are meant to be appended on and on and not rewind back in time a replot new (more detailed metrics). So this required a bit more change. In order to use it add this in the code: ``` const z = d3.select("body").append("div") .attr("class", "zoom"); context.zoom(function(start, end) { console.log(`Doing a zoom from point ${start} to point ${end}`); context.zoom().zoomTime(start, end); }).render(z); ```
Configuration menu - View commit details
-
Copy full SHA for 9e8f0d2 - Browse repository at this point
Copy the full SHA 9e8f0d2View commit details -
Support custom class name for horizon, title, ...
When trying to integrate with Grafana we need to use emotion that will generate its own classname instead of well known ones
Configuration menu - View commit details
-
Copy full SHA for 5290a1b - Browse repository at this point
Copy the full SHA 5290a1bView commit details -
Fix rollup config to allow typescript files
Signed-off-by: Matthieu Patou <mat@matws.net>
Configuration menu - View commit details
-
Copy full SHA for c31359f - Browse repository at this point
Copy the full SHA c31359fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 509217f - Browse repository at this point
Copy the full SHA 509217fView commit details
Commits on May 1, 2024
-
Increase coverage by improving e2e and unit testing
Significantly redesigned the e2e testing to allow testing of zooming and checking that values changes if we wait enough in e2e. Add also unit testing.
Configuration menu - View commit details
-
Copy full SHA for 1c69705 - Browse repository at this point
Copy the full SHA 1c69705View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f6ba2f - Browse repository at this point
Copy the full SHA 6f6ba2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9802bb - Browse repository at this point
Copy the full SHA d9802bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for eba07be - Browse repository at this point
Copy the full SHA eba07beView commit details
Commits on May 2, 2024
-
Fix mismatch in the names of artifacts
The names were not the same between the step that created it and the step that downloaded it.
Configuration menu - View commit details
-
Copy full SHA for 9df4939 - Browse repository at this point
Copy the full SHA 9df4939View commit details
There are no files selected for viewing