support quotes & credentials in mirror config #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change performs two parts. The first is removing any extra quotes from the configuration file so the examples in the README work as expected. The second is supporting HTTP Basic Authentication credentials within the mirror argument itself so for folks fetching from a source that requires authentication they are able to do so.
|
Hi, thanks for the patch! Could you, please, add some tests? |
|
Hi! I'm not aware of any open source HTTP mirrors that would allow for sending authentication to them, is there perhaps a mirror you know of (or a way you were hoping to see it mocked? I don't see any mocks currently in tree). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #321
this change performs two parts. The first is removing any extra quotes from the configuration file so the examples in the README work as expected.
The second is supporting HTTP Basic Authentication credentials within the mirror argument itself so for folks fetching from a source that requires authentication they are able to do so.