Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setuptools runtime dependency with packaging #337

Closed
flying-sheep opened this issue Jul 11, 2023 · 1 comment · Fixed by #338
Closed

Replace setuptools runtime dependency with packaging #337

flying-sheep opened this issue Jul 11, 2023 · 1 comment · Fixed by #338

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Jul 11, 2023

You import pkg_resources, which is deprecated. For object oriented handling of versions, you should use packaging.version instead.

grafik

@anisse
Copy link

anisse commented Aug 29, 2023

In addition to the warning in the docs, it generates a warning in requirements.txt when using generating it with pip-compile :

# The following packages are considered to be unsafe in a requirements file:
setuptools==68.1.2 \
    --hash=sha256:3d4dfa6d95f1b101d695a6160a7626e15583af71a5f52176efa5d39a054d475d \
    --hash=sha256:3d8083eed2d13afc9426f227b24fd1659489ec107c0e86cec2ffdde5c92e790b
    # via nodeenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants