Changes policy lookup to look at controller's namespace and then fallback to model's namespace

[divoxx]

This is related to #172

Basically, if your model lives inside a namespace that would not be considered when falling back when looking up for the policy.

With this change, if one had a controller Api::V1::Foo::Bar and a model Foo::Bar, when looking for the policy it would try Api::V1::Foo::BarPolicy and then BarPolicy. Now it will look for Foo::BarPolicy.

[shekibobo]

I just tested this, and what I'm seeing is this:

Pundit::NotDefinedError:
       unable to find scope [Object::AudioPolicy::Scope, ActiveRecord::AudioPolicy::Scope] for #<ActiveRecord::Relation::ActiveRecord_Relation_Media_Audio:0x007fbbdf19dfc8>

Instead of looking up Media::AudioPolicy, it's looking up Object::AudioPolicy. This is happening in all cases of namespaced models. The top-level namespace module is simply being replaced with Object.

[divoxx]

@shekibobo how are your controller and models defined?

[shekibobo]

My controllers are under the Admin namespace. My models are not, but some are namespaced, such as Media::Audio, Media::Video, etc. Any models that are namespaced like that end up with the Object::<demodulized_class_name>Policy lookup failing. My policies are defined like so;

app/
  policies/
    media/
      audio_policy.rb
      video_policy.rb
    application_policy.rb

[divoxx]

What about the FQN for the controller and model? Admin::Media::AudioController and Media::Audio ?

[divoxx]

@shekibobo I pushed a new change, can you try again?

[shekibobo]

Now it looks like it's trying to call ::Scope directly on whatever the object is.

Pundit::NotDefinedError:
   unable to find scope ::Scope for #<ActiveRecord::Relation::ActiveRecord_Relation_Catalog_Category:0x007fe61c96b860>
     # ~/.gem/ruby/2.1.2/bundler/gems/pundit-610c2722a33d/lib/pundit/policy_finder.rb:29:in `scope!'
     # ~/.gem/ruby/2.1.2/bundler/gems/pundit-610c2722a33d/lib/pundit.rb:26:in `policy_scope!'
     # ...

Pundit::NotDefinedError:
   unable to find scope ::Scope for Analytics::LogEntry

[jnicklas]

Support for namespaces has been removed, so this is no longer valid.