Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Update Metadata workflow should not be started when preceding workflows failed #915

Closed
tibroc opened this issue Jan 24, 2024 · 1 comment
Assignees
Labels
priority:medium type:usability v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x

Comments

@tibroc
Copy link

tibroc commented Jan 24, 2024

Currently the cronjobs seem to trigger update metadata workflows even if the initial workflow of the event failed (see #910). This has a confusing effect in opencast because the event will be shown in the admin UI as "finished" instead of "failed" because the update metadata workflow finished correctly (although the overall event status should still be failed).

@tibroc tibroc added v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x priority:medium type:usability labels Jan 24, 2024
@dennis531 dennis531 self-assigned this Jan 30, 2024
@dennis531
Copy link
Collaborator

dennis531 commented Jan 30, 2024

I think you mean the republish-metadata workflow. The workflow is triggered after editing the video in the UI and in the checkEventACL function triggered by the "Opencast - Queue" cronjob:

$workflow_client->republish($video->episode);

After #916 this workflow should not be triggered by the cronjob anymore when uploading videos. Still, this workflow is executed for recordings in OC Studio, as Studio runs independently of this plugin and does not set the required ACLs. One problem is that the plugin does not know the event ID of the recorded video a priori.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium type:usability v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Development

No branches or pull requests

2 participants