Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the serverless-offline startup hook #105

Closed
wants to merge 1 commit into from

Conversation

darthtrevino
Copy link

I'm having trouble with the serverless-offline startup hooks in the latest version of serverless-offilne. It seems like you have to bind to the offline:start:init event in order to have things boot properly into the serverless-offline cycle.

@fragosti
Copy link

When will this get merged? Seems pretty important.

@RuslanZavacky
Copy link

Hey guys, any updates? :) would be awesome to have this merged :)

@pie6k
Copy link

pie6k commented May 8, 2017

Any update?

@HyperBrain
Copy link
Member

@darthtrevino Is this still an issue? We're using the master branch since quite a long time (which does not have the changes), but using serverless-offline works quite well.

@HyperBrain
Copy link
Member

I think @Whoaa512 just got it working too, without this PR.

@Whoaa512
Copy link

As long as you have both plugins in your serverless.yml (with offline as the last plugin) and you run the command sls offline both plugins should work properly.

@HyperBrain
Copy link
Member

The implementation in #131 is more complete and also keeps the start hook too. I will close this one in favor of #131. Can you please test with that?

@HyperBrain
Copy link
Member

I tested #131 also for incompatibilities when using offline without the start argument. Works. So I'll close this one in favor of #131 as it is more complete.

@HyperBrain HyperBrain closed this Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants