Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CORS to use allowed headers from yml #106

Closed
wants to merge 1 commit into from
Closed

Update CORS to use allowed headers from yml #106

wants to merge 1 commit into from

Conversation

dolfelt
Copy link

@dolfelt dolfelt commented Feb 23, 2017

When using additional custom CORS headers in Serverless, the local serverless webpack serve command does not allow those headers when developing locally. This fixes that.

@jelder
Copy link

jelder commented Apr 17, 2017

Is this a duplicate of #74?

@HyperBrain HyperBrain mentioned this pull request Jun 30, 2017
Closed
@HyperBrain
Copy link
Member

@dolfelt It would be great if you could comment in #135 if you use the serve functionality or not, so that we can decide how to proceed there.

@HyperBrain
Copy link
Member

serve will be removed in the next v3.0.0 release in favor of serverless-offline (see #152 ). No efforts will be spent on the function anymore. So I'll close this issue.

@HyperBrain HyperBrain closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dolfelt @jelder @HyperBrain