Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.md #132

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Conversation

Gregoirevda
Copy link
Contributor

This is part off this change in serverless-webpack: #131
Explain how to work with the serverless-offline, serverless-webpack and serverless-dynamodb-local

This is part off this change in serverless-webpack: serverless-heaven#131
Explain how to work with the serverless-offline, serverless-webpack and serverless-dynamodb-local
README.md Outdated
@@ -171,6 +171,18 @@ Options are:
- `--function` or `-f` (required) is the name of the function to run
- `--path` or `-p` (optional) is a JSON file path used as the function input event

### Using with serverless-offline and serverless-webpack plugin

Run `serverless offline start`. In comparison with `serverless offline`, the `start` command will fire an `init` and a `end` lifecycle hook which is needed for serverless-offline and serverless-dynamodb-local to switch off both ressources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo of 'resources' at the end of the line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just deleted the s

@hassankhan
Copy link
Contributor

hassankhan commented Jul 2, 2017

/cc @HyperBrain, although this should probably only be merged #131

@HyperBrain
Copy link
Member

Agree. I've tested #131 until tomorrow, to check if it does not break using offline without start. Will merge the doc changes after #131 has been merged.

@hassankhan
Copy link
Contributor

hassankhan commented Jul 3, 2017

GTM I think 👍

@HyperBrain
Copy link
Member

@hassankhan Yes, you're right.

@HyperBrain HyperBrain merged commit f215f49 into serverless-heaven:master Jul 3, 2017
HyperBrain pushed a commit that referenced this pull request Jul 3, 2017
HyperBrain pushed a commit that referenced this pull request Jul 4, 2017
Added #144

Added #132

Added #141

Added #140 and #131

Added release notes
HyperBrain pushed a commit that referenced this pull request Jul 4, 2017
Added #144

Added #132

Added #141

Added #140 and #131

Added release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants