-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook for deploying individual functions #91
Conversation
I can verify that this works. Would love to get this merged. |
Actually @johnf, I think you need to add |
@mhodgson you're right. Have just fixed that |
This would be wonderful. |
Would also love to see some docs go along with this PR to understand how it could be used. |
Hi Kia, It's nothing specific to serverless-webpack, it is just enabling standard serverless functionality. i.e. making sure that Docs at https://serverless.com/framework/docs/providers/aws/cli-reference/deploy-function/ |
@thenikso any chance of getting this merged for another rc before 1.0.0 release? |
Any chance we could pull this in? |
Also would really like to get this in asap. |
@thenikso is there any word on this PR? Would like to try avoid needing to fork this :/ |
Would also really love this to be merged. |
Big +1, getting |
I think that's worth an issue in Serverless. The reason most likely is, that SLS does set the DeletionPolicy of the deployed function versions to "Retain", which will never delete any deployed version. Then you'll run out of code storage sooner or later. |
I'm not quite sure where the bug is, @HyperBrain 😕 . Spent most of last night trying to repair things as there was an issue with bundling. I have 19 functions, which together add up to ~40MB. With I started getting those errors, and incorrectly assumed it was to do with individual Lambda size. After much tinkering with Webpack, I reduced individual function size but continued to receive the same error on various functions upon CloudFormation deploy. Some of our other projects that are built by CI started failing with the same error, which caused a bit of a freakout 😓. I finally clued onto the fact that I'd hit the 75GB hard limit by going to the Web Console and clicking Lambda. However, the Console was reporting total Lambda size as just over 1GB. It was then when I remembered that all deployed functions are kept unless pruned, so I tried to remove the stack but at this point CloudFormation was stuck in a After fixing that, I was finally able to remove the stack and redeploy. I'm still looking into why the packaging is weird - for now the only fix I have is to use serverless-prune-plugin till I figure it out. |
@johnf @mhodgson @blakedietz @SkippyZA @ShaunEgan @deathweaselx86 @hassankhan |
I think I commented in one of the others that I also prefer #130. I didn't close this for some reason though! |
As discussed in #60