Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derived document mapping should use same privacy as document #78

Open
KodrAus opened this issue Jun 11, 2017 · 0 comments
Open

Derived document mapping should use same privacy as document #78

KodrAus opened this issue Jun 11, 2017 · 0 comments

Comments

@KodrAus
Copy link
Member

KodrAus commented Jun 11, 2017

When deriving ElasticType without mapping specified, you'll get one created for you called {DocType}Mapping.

Currently this mapping is public, even if the type you're deriving on isn't. We should either:

  • Make this mapping type unreachable if it's not defined by the caller (I prefer this one, but is a bigger change)
  • Use the privacy of the document type on the mapping type.

I personally like the first option and would like to see how that would work out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus