Add gh-aw guidance to Claude prompts#142
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/ai keep it specific to Claude please, Claude has no issues with pagination on mcp |
There was a problem hiding this comment.
APPROVE
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #142
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Removed the MCP pagination guidance from the Claude composite-action prompts to keep the instructions Claude-specific. Tests: What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #142 |
|
Summary: The Evidence from the job log: Recommended fix: run Tests: What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
/ai claude has no concept of |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Removed What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #142 |
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES.
The prompt updates are missing MCP pagination guidance in the newly ported guidance block, which leaves a known failure mode (oversized MCP responses) unaddressed.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #142
|
CI failure is caused by generated workflow artifacts being out of sync, not by a runtime/test failure.
What I verified locally:
Root cause:
Recommended fix:
I did not push a fix from this run because the required changes are in What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
/ai how does this look? are we doing anything crazy? |
|
Short answer: this looks sane, not crazy. I checked the current PR diff and the changes are tightly scoped to the 12 Claude action prompts under What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #142 |
Summary
Testing
make lintFixes Update Claude prompts to have best practices from our gh-aw workflows #132