Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 527] User-agent header for transport #1136

Closed
Tracked by #654
, #527
...
SylvainJuge opened this issue Oct 12, 2021 · 1 comment · Fixed by #1196
Closed
Tracked by #654
, #527
...

[META 527] User-agent header for transport #1136

SylvainJuge opened this issue Oct 12, 2021 · 1 comment · Fixed by #1196
Assignees
@axw
Labels
agent-go breaking change
Milestone
8.1

Comments

@SylvainJuge
Copy link
Member

Implement 514 for all APM agents.
@SylvainJuge SylvainJuge mentioned this issue Oct 12, 2021
Merged
@AlexanderWert AlexanderWert added this to the 8.0 milestone Oct 14, 2021
@zube zube bot added the [zube]: Ready label Oct 14, 2021
@AlexanderWert AlexanderWert changed the title [META 514] User-agent header for transport [META 527] User-agent header for transport Oct 19, 2021
@AlexanderWert AlexanderWert mentioned this issue Oct 19, 2021
Closed
7 tasks
@axw axw self-assigned this Dec 2, 2021
@axw
Copy link
Member

axw commented Dec 2, 2021

I think this is going to require breaking changes to our API. Service name and version are properties of the tracer. A transport (which defines the User-Agent) can be shared by multiple tracers. We use transport.Default if one is not specified when constructing a tracer, so we can't reasonably update its User-Agent.

I think we'll need to get rid of the transport.Default singleton, and always construct one when creating a tracer.

@axw axw removed their assignment Dec 2, 2021
@axw axw mentioned this issue Dec 2, 2021
Closed
@simitt simitt modified the milestones: 8.0, 8.1 Dec 17, 2021
This was referenced Jan 14, 2022
Closed
Closed
@axw axw self-assigned this Jan 18, 2022
@axw axw mentioned this issue Jan 18, 2022
Merged
@axw axw closed this as completed in #1196 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axw axw

Labels
agent-go breaking change
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Include service name and version in User-Agent axw/apm-agent-go
4 participants
@SylvainJuge @axw @AlexanderWert @simitt