Skip to content

Commit 2f8cd6f

Browse files
committed
Minor formatting and cleanup
1 parent d14f33e commit 2f8cd6f

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

apm-agent-plugins/apm-servlet-plugin/src/main/java/co/elastic/apm/agent/servlet/InitServiceNameInstrumentation.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,19 @@ public ElementMatcher<? super NamedElement> getTypeMatcherPreFilter() {
5959

6060
@Override
6161
public ElementMatcher<? super TypeDescription> getTypeMatcher() {
62-
return not(isInterface()).and(hasSuperType(namedOneOf("javax.servlet.ServletContextListener", "javax.servlet.Filter", "jakarta.servlet.ServletContextListener", "javax.servlet.Servlet", "jakarta.servlet.Filter", "jakarta.servlet.Servlet")));
62+
return not(isInterface()).and(hasSuperType(namedOneOf(
63+
"javax.servlet.ServletContextListener", "javax.servlet.Filter", "javax.servlet.Servlet",
64+
"jakarta.servlet.ServletContextListener", "jakarta.servlet.Filter", "jakarta.servlet.Servlet")));
6365
}
6466

6567
@Override
6668
public ElementMatcher<? super MethodDescription> getMethodMatcher() {
67-
return named("init").and(takesArguments(1).and(takesArgument(0, nameEndsWith("Config"))))
68-
.or(named("contextInitialized").and(takesArguments(1).and(takesArgument(0, nameEndsWith("ServletContextEvent")))));
69+
return named("init")
70+
.and(takesArguments(1))
71+
.and(takesArgument(0, nameEndsWith("Config")))
72+
.or(named("contextInitialized")
73+
.and(takesArguments(1))
74+
.and(takesArgument(0, nameEndsWith("ServletContextEvent"))));
6975
}
7076

7177
public static class JavaxInitServiceNameInstrumentation extends InitServiceNameInstrumentation {
@@ -80,9 +86,6 @@ public String rootClassNameThatClassloaderCanLoad() {
8086
public static class AdviceClass {
8187
@Advice.OnMethodEnter(suppress = Throwable.class, inline = false)
8288
public static void onEnter(@Advice.Argument(0) @Nullable Object arg) {
83-
if (arg == null) {
84-
return;
85-
}
8689
javax.servlet.ServletContext servletContext;
8790
if (arg instanceof javax.servlet.FilterConfig) {
8891
servletContext = adapter.getServletContextFromFilterConfig((javax.servlet.FilterConfig) arg);
@@ -111,9 +114,6 @@ public static class AdviceClass {
111114

112115
@Advice.OnMethodEnter(suppress = Throwable.class, inline = false)
113116
public static void onEnter(@Advice.Argument(0) @Nullable Object arg) {
114-
if (arg == null) {
115-
return;
116-
}
117117
jakarta.servlet.ServletContext servletContext;
118118
if (arg instanceof jakarta.servlet.FilterConfig) {
119119
servletContext = adapter.getServletContextFromFilterConfig((jakarta.servlet.FilterConfig) arg);

0 commit comments

Comments
 (0)