Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metrics / Stats API #112

Closed
alvarolobato opened this issue Jun 28, 2018 · 7 comments
Closed

Add support for Metrics / Stats API #112

alvarolobato opened this issue Jun 28, 2018 · 7 comments
Assignees

Comments

@alvarolobato
Copy link
Contributor

alvarolobato commented Jun 28, 2018

Work is underway to add support for Metrics to the API/server: elastic/apm-server#964
Support needs to be added to this agent too.

The default minimum set of metrics should be supported. TBD which additional metrics will be supported for this agent.

@cah-andrew-fitzgerald
Copy link

Are there plans for this to work with existing metrics libraries?
Would be nice for this to support micrometer, which is the default for Spring.

@felixbarny
Copy link
Member

Micrometer is definitely on our radar and we'll evaluate possible integrations.

@jkschneider
Copy link

I'd love to see a spec around what the apm-server expects, as for Micrometer ideally we'd support shipping directly to API rather than through the agent. Agents aren't altogether bad, but they can be unacceptable in certain environments.

@felixbarny
Copy link
Member

There is no such spec yet, but you will be kept up-to-date by subscribing to this issue.

@alvarolobato alvarolobato self-assigned this Oct 24, 2018
@alvarolobato alvarolobato added this to the current milestone Nov 9, 2018
@alvarolobato alvarolobato removed their assignment Nov 19, 2018
@jkschneider
Copy link

@eyalkoren That doc is not shared.

@eyalkoren
Copy link
Contributor

@jkschneider right, thanks! It's not shared because it is still WIP, my fault of referring to it from here. In any case, we may start with just supporting basic JMX stuff and maybe extend later on to do some integrations

@felixbarny
Copy link
Member

This PR added basic support for metrics: #360

Note that there is no public API to add metrics. Instead of building an API ourselves, I think it makes more sense to write an Elastic APM reporter for micrometer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants