Skip to content

Commit 2643022

Browse files
committed
fix: correct dev-deps required for the recent estlin@8 upgrade
The upgrade to eslint@8 in #3409 subtly broken peer-dependencies. `npm ls` unhelpfully does not complain, but `npm ls -a` shows some errors, and `./dev-utils/make-distribution.sh` was broken. The upgrade bumped "eslint-config-standard" from ^14.1.1 to ^16. However, v16 has: "peerDependencies": { "eslint": "^7.12.1", "eslint-plugin-import": "^2.22.1", "eslint-plugin-node": "^11.1.0", "eslint-plugin-promise": "^4.2.1 || ^5.0.0" }, so is incompatible with eslint@8. We need eslint-config-standard@17, which has: "peerDependencies": { "eslint": "^8.0.1", "eslint-plugin-import": "^2.25.2", "eslint-plugin-n": "^15.0.0 || ^16.0.0 ", "eslint-plugin-promise": "^6.0.0" }, Note that also requires a change from eslint-plugin-node (unmaintained) to the replacement "eslint-plugin-n".
1 parent d8acbf2 commit 2643022

File tree

2 files changed

+169
-73
lines changed

2 files changed

+169
-73
lines changed

package-lock.json

+167-71
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@
149149
"diagnostics_channel": "^1.1.0",
150150
"elasticsearch": "^16.7.3",
151151
"eslint": "^8.42.0",
152-
"eslint-config-standard": "^16",
152+
"eslint-config-standard": "^17.1.0",
153153
"eslint-plugin-import": "^2.27.5",
154154
"eslint-plugin-license-header": "^0.6.0",
155-
"eslint-plugin-node": "^11.1.0",
155+
"eslint-plugin-n": "^15.7.0",
156156
"eslint-plugin-promise": "^6.1.1",
157157
"express": "^4.17.1",
158158
"express-queue": "^0.0.13",

0 commit comments

Comments
 (0)