Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user-agent header #1253

Closed
watson opened this issue Aug 2, 2019 · 1 comment
Closed

Improve user-agent header #1253

watson opened this issue Aug 2, 2019 · 1 comment
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@watson
Copy link
Contributor

watson commented Aug 2, 2019

The user agent was updated recently (#1238) from:

{package-name}/{package-version}

to:

{agent-name}/{package-version}

Following discussion, we're updating it once more to get the package-name back into the header:

{agent-name}/{package-version} {package-name}/{package-version}

I propose also that we call the agent-name elasticapm-nodejs instead of elasticapm-node while we're at it. The duplicate package-version is intentional (see discussion).

@trentm trentm added [zube]: Backlog agent-nodejs Make available for APM Agents project planning. labels Nov 10, 2020
@trentm
Copy link
Member

trentm commented Jul 27, 2022

The user-agent was spec'd to be $repoName/$version ($serviceName $serviceVersion) at https://github.com/elastic/apm/blob/main/specs/agents/transport.md#user-agent

And that was implemented in #2402 a while back.

@trentm trentm closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

2 participants