Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove passing component property when route is not instrumented #401

Closed
vigneshshanmugam opened this issue Aug 29, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@vigneshshanmugam
Copy link
Member

  • When the component property is not instrumented via <ApmRoute> component, we should not override the props passed down to Route component. This creates a memory leak warning in React and also its a bug in general.

https://github.com/elastic/apm-agent-rum-js/blob/master/packages/rum-react/src/get-apm-route.js#L36

Found this while instrumenting Kibana

@vigneshshanmugam
Copy link
Member Author

After double checking, ruled out that this is not the source of the memory leak warning that gets logged. the component property would be undefined which would be ignored by React Route component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant