Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event.success_count metric should use representative count #388

Open
lahsivjar opened this issue Oct 22, 2024 · 1 comment · May be fixed by elastic/elasticsearch#119995
Open

event.success_count metric should use representative count #388

lahsivjar opened this issue Oct 22, 2024 · 1 comment · May be fixed by elastic/elasticsearch#119995
Assignees
Labels
bug Something isn't working

Comments

@lahsivjar
Copy link
Contributor

lahsivjar commented Oct 22, 2024

event.success_count attribute is populated using ingest pipeline defined in apm-data plugin. The attribute currently is populated using 1 for success spans and 0 for failed spans, however, when we aggregate this metric, we use representative count (ref) which should be more apt for what we do with this metric.

The issue is about fixing the ingest pipeline to use representative count if defined, 1 otherwise in the ingest pipeline for cases when the event.outcome is success.

Related to: elastic/opentelemetry-lib#112

@raultorrecilla
Copy link

moving this to it106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants