-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels
and deprecate tags
on Intake API
#1835
Comments
I vote for Option 1, tags in the context always felt a bit awkward |
I also vote on 1 as we are planning to remove context from the intake api anyway now that there is no context in ES documents as of 7.0 (#411). |
closing for now, will reopen if we decide to tackle this for 8.0 |
When we implement this we should probably deprecate |
Follow up from #1826:
Change Intake API to allow for sending
labels
rather thantags
:Option (1):
deprecate current:
{ transaction: context: { tags: {}}}
introduce:
{ transaction: labels: {}, context: {}}
Option (2):
deprecate current:
{ transaction: context: { tags: {}}}
introduce:
{ transaction: context: { labels: {}}}
Option (3) - keep what we have:
{ transaction: context: { tags: {}}}
The format would be the same for
errors
andspans
.@elastic/apm-agent-devs please vote on what you'd prefer
The text was updated successfully, but these errors were encountered: